Skip to content

[Type Hints] nn.max_pool #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2022
Merged

[Type Hints] nn.max_pool #5735

merged 3 commits into from
Oct 17, 2022

Conversation

shhs29
Copy link
Contributor

@shhs29 shhs29 commented Oct 16, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2022 •
edited
Loading

Codecov Report

Merging #5735 (c4f042e) into master (08ce16b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c4f042e differs from pull request most recent head 1776f47. Consider uploading reports for the commit 1776f47 to get more accurate results

@@            Coverage Diff             @@
##           master    #5735      +/-   ##
==========================================
- Coverage   84.03%   84.03%   -0.01%     
==========================================
  Files         349      349              
  Lines       19303    19300       -3     
==========================================
- Hits        16221    16218       -3     
  Misses       3082     3082
Impacted Files Coverage Δ
torch_geometric/nn/pool/max_pool.py 100.00% <100.00%> (ø)
torch_geometric/nn/pool/avg_pool.py 100.00% <0.00%> (ø)
torch_geometric/transforms/to_superpixels.py 100.00% <0.00%> (ø)
torch_geometric/transforms/target_indegree.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shhs29 shhs29 marked this pull request as ready for review October 16, 2022 17:57
@shhs29 shhs29 changed the title Add type hints for max pool [Type Hints] nn.max_pool Oct 16, 2022
wsad1
wsad1 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@wsad1 wsad1 enabled auto-merge (squash) October 17, 2022 04:36
@wsad1 wsad1 merged commit a859025 into pyg-team:master Oct 17, 2022
@wsad1 wsad1 mentioned this pull request Oct 17, 2022
Closed
jjpietrak pushed a commit to jjpietrak/pytorch_geometric that referenced this pull request Nov 25, 2022
@shhs29 @wsad1
[Type Hints] nn.max_pool (pyg-team#5735)
adb6028 
Co-authored-by: Jinu Sunil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 wsad1 approved these changes

Assignees

@shhs29 shhs29

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shhs29 @wsad1 @rusty1s