Skip to content

Add max_num_elements parameter to the forward method of aggregation layers #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

piotrchmiel
Copy link
Contributor

GraphMultisetTransformer, GRUAggregation, LSTMAggregation, SetTransformerAggregation layers.

@piotrchmiel piotrchmiel requested a review from EdisonLeeeee as a code owner June 6, 2023 11:31
@piotrchmiel piotrchmiel force-pushed the pchmiel/max_num_nodes branch from 572be21 to ae35840 Compare June 6, 2023 11:39
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #7529 (e7f0efe) into master (4179337) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e7f0efe differs from pull request most recent head 3162828. Consider uploading reports for the commit 3162828 to get more accurate results

@@           Coverage Diff           @@
##           master    #7529   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         447      447           
  Lines       24898    24898           
=======================================
  Hits        22754    22754           
  Misses       2144     2144           
Impacted Files Coverage Δ
torch_geometric/nn/aggr/gmt.py 100.00% <100.00%> (ø)
torch_geometric/nn/aggr/gru.py 100.00% <100.00%> (ø)
torch_geometric/nn/aggr/lstm.py 100.00% <100.00%> (ø)
torch_geometric/nn/aggr/set_transformer.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@piotrchmiel piotrchmiel force-pushed the pchmiel/max_num_nodes branch from ae35840 to 2fb3100 Compare June 6, 2023 11:42
…setTransformer`, `GRUAggregation`, `LSTMAggregation`, `SetTransformerAggregation` layers.
@piotrchmiel piotrchmiel force-pushed the pchmiel/max_num_nodes branch from 2fb3100 to e7f0efe Compare June 6, 2023 11:42
@piotrchmiel piotrchmiel changed the title Add max_num_nodes parameter to the forward method of aggregation layers. Add max_num_elements parameter to the forward method of aggregation layers. Jun 6, 2023
@rusty1s rusty1s changed the title Add max_num_elements parameter to the forward method of aggregation layers. Add max_num_elements parameter to the forward method of aggregation layers Jun 6, 2023
@rusty1s rusty1s enabled auto-merge (squash) June 6, 2023 13:43
@rusty1s rusty1s merged commit 0f0e0da into pyg-team:master Jun 6, 2023
@piotrchmiel piotrchmiel deleted the pchmiel/max_num_nodes branch June 7, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants