Skip to content

fix: wrong initialization in DimeNet output block #7774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

ATheCoder
Copy link
Contributor

@ATheCoder ATheCoder commented Jul 19, 2023

Fixes: #7762

@ATheCoder ATheCoder requested a review from EdisonLeeeee as a code owner July 19, 2023 12:09
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #7774 (4a23ed5) into master (a90949d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 4a23ed5 differs from pull request most recent head 9e9ccc0. Consider uploading reports for the commit 9e9ccc0 to get more accurate results

@@            Coverage Diff             @@
##           master    #7774      +/-   ##
==========================================
+ Coverage   91.56%   91.61%   +0.04%     
==========================================
  Files         452      452              
  Lines       25547    25526      -21     
==========================================
- Hits        23392    23385       -7     
+ Misses       2155     2141      -14     
Impacted Files Coverage Δ
...h_geometric/contrib/explain/graphmask_explainer.py 90.34% <100.00%> (+4.27%) ⬆️
torch_geometric/nn/models/dimenet.py 99.67% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title fix: wrong initialization in dimenet output block fix: wrong initialization in DimeNet output block Jul 19, 2023
@rusty1s rusty1s enabled auto-merge (squash) July 19, 2023 13:22
@rusty1s rusty1s merged commit 7a395bf into pyg-team:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The DimeNet implementation always returns 0.
2 participants