-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Moved GraphMaskExplainer
to torch_geometric.explain
#7779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we fix the diff here once again? |
Codecov Report
@@ Coverage Diff @@
## master #7779 +/- ##
==========================================
- Coverage 90.12% 89.43% -0.70%
==========================================
Files 458 456 -2
Lines 26874 26773 -101
==========================================
- Hits 24221 23945 -276
- Misses 2653 2828 +175
... and 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I just added |
Mh, not really. It still shows full deletion/addition of the code. Let me see what I can do. |
Yeah, sure. Please let me know if I missed out on committing to this PR any imperative code file which causes this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue around the line endings should be resolved now.
Just curious, what text editor and version of git are you using? 👀
GraphMaskExplainer
GraphMaskExplainer
to torch_geometric.explain
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fork123aniket Thank you for working on this. LGTM!
Thanks, @akihironitta. Really appreciate your help here. @rusty1s @akihironitta When can we expect to have this PR merged, given the changes associated with this PR have already been approved?? |
Thanks for taking care of merging. |
Co-authored-by: Akihiro Nitta <[email protected]>
As discussed in #7271 (reply in thread), have attached all the relevant code files to this PR that actually could aid in the final migration of
GraphMaskExplainer
fromtorch_geometric.contrib.explain
totorch_geometric.explain
.