Skip to content

Account for unsorted inputs when computing e_id in NeighborSampler #7953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 30, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Aug 30, 2023

No description provided.

@rusty1s rusty1s self-assigned this Aug 30, 2023
@rusty1s rusty1s requested review from wsad1, mananshah99 and a team as code owners August 30, 2023 08:57
@github-actions github-actions bot removed the sampler label Aug 30, 2023
@rusty1s rusty1s changed the title Account for non-sorted inputs when computing e_id in NeighborSampler Account for unsorted inputs when computing e_id in NeighborSampler Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #7953 (d67cb1f) into master (2febd38) will decrease coverage by 0.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7953      +/-   ##
==========================================
- Coverage   90.20%   89.44%   -0.77%     
==========================================
  Files         459      459              
  Lines       26943    26948       +5     
==========================================
- Hits        24305    24103     -202     
- Misses       2638     2845     +207     
Files Changed Coverage Δ
torch_geometric/loader/link_neighbor_loader.py 100.00% <ø> (ø)
torch_geometric/loader/neighbor_loader.py 92.30% <ø> (ø)
torch_geometric/loader/link_loader.py 96.29% <100.00%> (+0.14%) ⬆️
torch_geometric/loader/node_loader.py 96.34% <100.00%> (+0.18%) ⬆️

... and 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 6405852 into master Aug 30, 2023
@rusty1s rusty1s deleted the link_fix branch August 30, 2023 10:33
erfanloghmani pushed a commit to erfanloghmani/pytorch_geometric that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant