Skip to content

Handle reserved keywords as keys in ModuleDict and ParameterDict #8163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2023
Merged

Handle reserved keywords as keys in ModuleDict and ParameterDict #8163

merged 3 commits into from
Oct 9, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Oct 9, 2023

@rusty1s rusty1s self-assigned this Oct 9, 2023
@rusty1s rusty1s changed the title Handle reserved keywords in ModuleDict and ParameterDict Handle reserved keywords as keys in ModuleDict and ParameterDict Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #8163 (b04133d) into master (f71ead8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b04133d differs from pull request most recent head 5496e96. Consider uploading reports for the commit 5496e96 to get more accurate results

@@           Coverage Diff           @@
##           master    #8163   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files         473      473           
  Lines       28570    28578    +8     
=======================================
+ Hits        24972    24980    +8     
  Misses       3598     3598
Files Coverage Δ
torch_geometric/nn/module_dict.py 100.00% <100.00%> (ø)
torch_geometric/nn/parameter_dict.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 98ffec4 into master Oct 9, 2023
@rusty1s rusty1s deleted the module_dict_reserved_keys branch October 9, 2023 20:34
@stadlmax stadlmax mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keys of a ModuleDict cannot have the same name as existing ModuleDict class attributes.
1 participant
@rusty1s