-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Improved distributed tests #8978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved distributed tests #8978
Conversation
cf1e0aa
to
3dfab31
Compare
23f6716
to
3ca6a06
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8978 +/- ##
==========================================
- Coverage 89.87% 89.15% -0.72%
==========================================
Files 468 469 +1
Lines 30054 30106 +52
==========================================
- Hits 27010 26840 -170
- Misses 3044 3266 +222 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we might need to keep an eye on dist tests after this is merged
@arlesniak we need to look into thos CI issues first |
26a5770
to
cbb8dfd
Compare
e86b339
to
4811b97
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing :)
This PR fixes distributed tests in cases when an Exception raised in subprocess is not correctly manifested to pytest, finally reported as PASSED, causing false positive result.
Changes made:
assert_run_mproc
test utility function for decorating and running ProcessesMPCaptOutput
context utility class, capturing std output and stderr