Skip to content

Raise save errors #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Raise save errors #615

merged 2 commits into from
Mar 7, 2025

Conversation

liamhuber
Copy link
Member

The pickle storage back end wasn't actually raising unavoidable errors in the save process! So it would just silently fail. Here, we catch and raise any error that remains when we've exhausted our attacks (in this case, pickle and cloudpickle).

Identified in #614. If the data there is indeed un-cloudpickle-able, then this also closes that issue.

Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Copy link

github-actions bot commented Mar 7, 2025

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/raise_save_errors

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (edc4245) 3439 3143 91.39%
Head commit (0c4fb0d) 3441 (+2) 3147 (+4) 91.46% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#615) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13726349783

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 91.456%

Totals Coverage Status
Change from base Build 13710178513: 0.06%
Covered Lines: 3147
Relevant Lines: 3441

💛 - Coveralls

@liamhuber liamhuber merged commit 9075529 into main Mar 7, 2025
20 of 21 checks passed
@liamhuber liamhuber deleted the raise_save_errors branch March 7, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants