Clean names multiindex #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmjl
reviewed
Mar 22, 2018
| .replace('.', '_') | ||
| ) | ||
|
|
||
| df = df.rename(columns=lambda x: re.sub('_+', '_', x)) |
ericmjl
reviewed
Mar 22, 2018
| df = pd.DataFrame(data) | ||
| return df | ||
|
|
||
|
|
There was a problem hiding this comment.
Wonderful, thanks for following the programming pattern!
ericmjl
reviewed
Mar 22, 2018
| labels = [[0, 1, 2], [0, 1, 2]] | ||
|
|
||
| expected_columns = pd.MultiIndex(levels=levels, labels=labels) | ||
| assert set(df.columns) == set(expected_columns) |
There was a problem hiding this comment.
Wow, you really went above-and-beyond here! Thanks for doing this!
There was a problem hiding this comment.
Thanks - My only thought on this was, should we be handling levels, labels and maybe expected_columns at a global level so that I am not just repeating the setup of variables? I am not experienced with writing test so I am not sure what is good or standard practice.
|
Thanks for your contribution, @JoshuaC3! I am going to merge. |
|
Thank you for the positive feedback. I learnt a lot contributing here. There are some other parts I that I think could be improved. I will raise some issues for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
cleaan_namesso that it works for MultiIndexes and also add tests for this.Fixes #10