-
Notifications
You must be signed in to change notification settings - Fork 173
Clean names remove outer underscores #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ericmjl
merged 8 commits into
pyjanitor-devs:master
from
JoshuaC3:clean_names-remove-outer-underscores
Mar 29, 2018
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d292b05
Merge pull request #1 from JoshuaC3/clean_names-multiindex
JoshuaC3 0a62978
Add strip_underscores
e8e6e8a
Add test for clean_names strip_underscores
d4ec01d
Add detailed function descriptions for clean_names and _strip_undersc…
de340d2
Add detailed function descriptions formatted.
ea74a28
Add left and right tests for clean_names strip_underscore.
c316427
Add tests for clean_names strip_underscores l, r and True.
be35c09
Improve 'both' and True tests.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the following on line 192:
df = multiindex_dataframe.rename(columns=lambda x: '_' + x)
Do you think we need the same before line 179?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need that for 'l' and 'left'. The original multiindex_dataframe has a right/trailing underscore on
r_i_p_rhino_
. There were no leading/left underscores so I added some withdf = multiindex_dataframe.rename(columns=lambda x: '_' + x)
. Is this ok?BTW, It was actually the trailing underscore in
r_i_p_rhino_
that made me think that this strip_underscores was needed!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I should add this line to
'both
' so that we test fully a mix of stripping lefts, rights and boths. Will add this now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok got it! Thanks for pointing it out, I should have read the code a bit more closely.