Skip to content

[DOC] Clarify Python version compatibility to >=py36 #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2019

Conversation

hectormz
Copy link
Collaborator

@hectormz hectormz commented Jul 21, 2019

PR Description

Please describe the changes proposed in the pull request:

  • Documentation for users and contributors explicitly state Python 3.6+ compatibility
  • black is configured to support python 3.6 & 3.7
  • setup.py requires Python 3.6+

This PR resolves #493.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.

Quick Check

To do a very quick check that everything is correct, follow these steps below:

  • Run the command make check from pyjanitor's top-level directory. This will automatically run:
    • black formatting
    • pycodestyle checking
    • running the test suite
    • docs build

Once done, please check off the check-box above.

If make check does not work for you, you can execute the commands listed in the Makefile individually.

Code Changes

If you are adding code changes, please ensure the following:

  • Ensure that you have added tests.
  • Run all tests ($ pytest .) locally on your machine.
    • Check to ensure that test coverage covers the lines of code that you have added.
    • Ensure that all tests pass.

Documentation Changes

If you are adding documentation changes, please ensure the following:

  • Build the docs locally.
  • View the docs to check that it renders correctly.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #497 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #497   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files           9        9           
  Lines         799      799           
=======================================
  Hits          740      740           
  Misses         59       59

@ericmjl ericmjl changed the title [DOC] Clarify Python version compatibility [DOC] Clarify Python version compatibility to >=py36 Jul 21, 2019
@ericmjl ericmjl merged commit bf4e5b3 into pyjanitor-devs:dev Jul 21, 2019
@hectormz hectormz deleted the python-versions branch July 30, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Clarify Python version requirements
2 participants