Skip to content

[ENH] Add snake option to clean_names #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2019
Merged

[ENH] Add snake option to clean_names #509

merged 3 commits into from
Jul 29, 2019

Conversation

ericmjl
Copy link
Member

@ericmjl ericmjl commented Jul 28, 2019

PR Description

Please describe the changes proposed in the pull request:

  • Adds the option to convert names to snake_case from camelCase.
  • Adds a bunch of tests relevant to the problem.
  • References the original implementation on GitHub Gists.

This PR resolves #498.

Relevant Reviewers

@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #509 into dev will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #509      +/-   ##
==========================================
+ Coverage   92.88%   92.94%   +0.06%     
==========================================
  Files           9        9              
  Lines         843      851       +8     
==========================================
+ Hits          783      791       +8     
  Misses         60       60

@ericmjl ericmjl merged commit e4fc730 into dev Jul 29, 2019
@ericmjl ericmjl deleted the camelcase-#498 branch July 29, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Add ability to convert CamelCase to snake_case by default in clean_names
1 participant