-
Notifications
You must be signed in to change notification settings - Fork 173
[DOC] Add PyPI description #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this, @hectormz! Just a question regarding whether we can reduce duplication in the code, mostly for maintenance purposes.
Codecov Report
@@ Coverage Diff @@
## dev #513 +/- ##
==========================================
- Coverage 92.88% 92.77% -0.12%
==========================================
Files 10 10
Lines 872 872
==========================================
- Hits 810 809 -1
- Misses 62 63 +1 |
@ericmjl Seems there is an issue finding the conda environment. In this change, I considering making a test, but was unsure how to test something in |
@hectormz, it's only failing on black at this point, I think! 😄 Could you black the entire codebase and push? |
Hi @ericmjl, |
All good! Thanks @hectormz! |
PR Description
Please describe the changes proposed in the pull request:
README.rst
for PyPI project descriptionThis PR resolves #495.
PR Checklist
Please ensure that you have done the following:
<your_username>
:master, but rather from<your_username>
:<branch_name>.AUTHORS.rst
.CHANGELOG.rst
under the latest version header (i.e. the one that is "on deck") describing the contribution.Quick Check
To do a very quick check that everything is correct, follow these steps below:
make check
from pyjanitor's top-level directory. This will automatically run:Once done, please check off the check-box above.
If
make check
does not work for you, you can execute the commands listed in the Makefile individually.Documentation Changes
If you are adding documentation changes, please ensure the following:
Relevant Reviewers
Please tag maintainers to review.