Skip to content

[DOC] Fix markdown level for intl teach notebook #476 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

jk3587
Copy link
Collaborator

@jk3587 jk3587 commented Aug 5, 2019

PR Description

Please describe the changes proposed in the pull request:

This PR resolves #476.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.rst under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Quick Check

To do a very quick check that everything is correct, follow these steps below:

  • Run the command make check from pyjanitor's top-level directory. This will automatically run:
    • black formatting
    • pycodestyle checking
    • running the test suite
    • docs build

Once done, please check off the check-box above.

If make check does not work for you, you can execute the commands listed in the Makefile individually.

Documentation Changes

If you are adding documentation changes, please ensure the following:

  • Build the docs locally.
  • View the docs to check that it renders correctly.

Relevant Reviewers

Please tag maintainers to review.

@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/ericmjl/pyjanitor/pull/523

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #523 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #523   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files          10       10           
  Lines         891      891           
=======================================
  Hits          828      828           
  Misses         63       63

@ericmjl
Copy link
Member

ericmjl commented Aug 5, 2019

Thank you, @jk3587! Going to hit the big green button! 😄

@ericmjl ericmjl merged commit 5746622 into pyjanitor-devs:dev Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] International Teacher Data notebook should not have 1st-level markdown beyond title
2 participants