-
Notifications
You must be signed in to change notification settings - Fork 173
[ENH] Attempt to fix issues 737, 198, 752, 209, 366, 382, 695 #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # janitor/functions.py
TODO: docstring
…eplaced by underscore
@BaritoneBeard it appears there's a conflict. I'm going to resolve it, but you might need to pull down changes before pushing any more changes that you make. |
@BaritoneBeard how are we doing here? Is there anything we could do to push this PR along? Most of what's failing is just the code style checks; everything else appears to be working fine! 😄 |
@ericmjl I just need to alter truncate_datetime and then I should be done on the code side. Also, for code style: darglint in particular was giving me trouble last I worked on this and I couldn't figure out what I was doing differently so I may be pinging you in the future for some assitance. First I'll work on the code, then fix the style when thats done. |
Awesomeness, @BaritoneBeard! Thanks for letting us know. No pressure, btw, just wanted to make sure the PR didn't get dropped, that's all, especially given the good stuff that's in there. Do make sure you enjoy your lunch breaks too! It's always important to get some rest in between. |
@BaritoneBeard are you encountering issues with |
Alrighty @ericmjl It seems my code stuff is finished, all thats left are some Linter compliance problems that I can't quite figure out, hoping you or another mod may be able to help out.
I see you've asked a question before I was able to comment. If a call is best for you that works for me, we can decide a date and time. If you've seen these particular errors before and know a quick solution you can just let me know and I can work with it some more. Whatever's easiest. |
@BaritoneBeard definitely, let's schedule a call. Can you send me an email via http://shortwhale.com/ericmjl? (I use Shortwhale to protect my email address from the public.) |
Hey @ericmjl I sent you an email a few weeks ago and haven't heard from you, no rush of course I just wanted to make sure you received it because if not I can simply send another. If you have received it an you're just busy, no worries I will continue to chill. |
Hey @BaritoneBeard! I searched in my Inbox and couldn't find any email from you. No worries, these things happen. Could you send it again? |
@ericmjl Sure thing, it's been sent just now so you should have it at this time |
@BaritoneBeard this is weird, I still haven't seen anything in my inbox sent from you via Shortwhale. No worries, can you send an email to me directly? Really sorry we ended up going back and forth on such a trivial matter. I'll want to see whether Shortwhale is working for you when we call too, so I can make a choice on whether I want to keep using it or not. |
Woohoo, we're all good! 😄 |
Writing down the context for future reference: @BaritoneBeard and I did a video call this evening to resolve issues that were preventing the PR checks from passing. |
PR Description
Please describe the changes proposed in the pull request:
**This PR resolves #737 **
**This PR resolves #198 **
**This PR resolves #752 **
**This PR resolves #209 **
**This PR resolves #366 **
**This PR resolves #382 **
**This PR resolves #695 **
PR Checklist
Please ensure that you have done the following:
Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.