[ENH] Minor fixes #833
Merged
[ENH] Minor fixes #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #833 +/- ##
==========================================
+ Coverage 95.26% 95.34% +0.07%
==========================================
Files 19 19
Lines 1966 1975 +9
==========================================
+ Hits 1873 1883 +10
+ Misses 93 92 -1 |
ericmjl
reviewed
May 17, 2021
Comment on lines
+71
to
+75
| expected = df.assign(s3=df.s1.combine_first(df.s2).fillna(0)) | ||
| result = df.coalesce( | ||
| ["s1", "s2"], target_column_name="s3", default_value=0 | ||
| ) | ||
| assert_frame_equal(result, expected) |
There was a problem hiding this comment.
This is a much nicer expression of the test!
ericmjl
reviewed
May 17, 2021
Comment on lines
-24
to
+26
| def test_update_where_query(): | ||
| """Test that function works with pandas query-style string expression.""" | ||
| df = pd.DataFrame( | ||
| @pytest.fixture | ||
| def df(): | ||
| return pd.DataFrame( |
ericmjl
approved these changes
May 17, 2021
There was a problem hiding this comment.
Excellent work, @samukweku! Thank you for handling these improvements. I am approving! Will let it simmer for one or two more days before we merge.
hectormz
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
coalescereturns the entire dataframe, along with a new column (iftarget_column_nameis not None)bfill(1).ffill(1)syntax, which is faster thanreduce(combine.first)default_valueparameter, to fill any remaining nulls.update_whereto usepd.evalfor string-like conditions.This PR resolves #831 .
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.rst.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.