Skip to content

[ENH] Updated convert_excel_date to throw meaningful error #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2021

Conversation

nvamsikrishna05
Copy link
Collaborator

@nvamsikrishna05 nvamsikrishna05 commented Jul 11, 2021

…ues are of type non-numeric

PR Description

Please describe the changes proposed in the pull request:

  • Updated convert_excel_date function to throw meaningful error when input column contains non-numeric data.

**This PR resolves #813 **

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku
Copy link
Collaborator

@nvamsikrishna05 kindly have a look at the failing checks and resolve

@nvamsikrishna05
Copy link
Collaborator Author

@samukweku I resolved the code formatting and linting check which were failing. Now they are passing. But one of the jupyter notebook is failing at the finance functions which wasn't modified in this pr.

I ran the same notebook in colab and it was running properly for me. Can you help me out with what's the issue ?

@samukweku
Copy link
Collaborator

@nvamsikrishna05 for the failing notebook, change current year value to int(x.name)

@nvamsikrishna05
Copy link
Collaborator Author

@samukweku Thanks, it worked. All Tests passed now. If you see there's no other issue you can merge the PR.

@samukweku
Copy link
Collaborator

@nvamsikrishna05 lets wait for another team member to review before merging

@nvamsikrishna05
Copy link
Collaborator Author

@samukweku sure. Thanks

@ericmjl
Copy link
Member

ericmjl commented Jul 12, 2021

@nvamsikrishna05, thank you for the contribution, and @samukweku thank you for reviewing the PR! I looked at it and I approve too. Going to hit merge.

@ericmjl ericmjl merged commit 055ce68 into pyjanitor-devs:dev Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_excel_date throws error when input contains strings
3 participants