Skip to content

[INF] GitHub Auto-Release Pointer #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2021
Merged

[INF] GitHub Auto-Release Pointer #842

merged 3 commits into from
Jul 17, 2021

Conversation

loganthomas
Copy link
Member

@loganthomas loganthomas commented Jul 17, 2021

PR Description

  • With a few simple lines added to .github/workflows/auto-release.yml, we can correctly reference (i.e. "point") to the latest release in the landing page of the GitHub repo. In addition, this will include a "prettier" interface when navigating the releases.
  • This has been tested on solid-octo-guac (thanks @ericmjl for keeping this up 😅 ) here
  • See https://github.com/ncipollo/release-action

This PR resolves #818

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  2. If you're not on the contributors list, add yourself to AUTHORS.rst.
  3. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

@samukweku and @jk3587 this will add a single step to the auto-release script.

Please tag maintainers to review.

@loganthomas loganthomas added enhancement New feature or request infrastructure Infrastructure-related issues labels Jul 17, 2021
@loganthomas loganthomas self-assigned this Jul 17, 2021
@ericmjl
Copy link
Member

ericmjl commented Jul 17, 2021

Wow, impressive, @loganthomas! Thanks for handling this. Love that you've been testing it on that dummy repo 😄!

@ericmjl
Copy link
Member

ericmjl commented Jul 17, 2021

@loganthomas please do the honors!

@loganthomas loganthomas merged commit 72e8109 into pyjanitor-devs:dev Jul 17, 2021
@loganthomas loganthomas deleted the auto-release-pointer branch July 17, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Infrastructure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INF] Fix GutHub release to point to actual latest
3 participants