Skip to content

[INF] Update code_check github actions black version #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

nvamsikrishna05
Copy link
Collaborator

@nvamsikrishna05 nvamsikrishna05 commented Jul 18, 2021

PR Description

Please describe the changes proposed in the pull request:

  • pre-commit hooks black version has been updated. github actions black version wasn't updated. Both versions are formatting rules are a bit differently causing conflicts.
  • Updated the black version in the code_checks yaml file to match the pre-commit hooks black version.
  • Updated the black version in the environment-dev yaml file.

**This PR resolves #846 **

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@nvamsikrishna05
Copy link
Collaborator Author

@ericmjl @loganthomas After updating the black version, black is showing more files to be updated compared to old version of black. Shall I proceed to format the files with new version of black and update the PR ?

@ericmjl
Copy link
Member

ericmjl commented Jul 18, 2021

@nvamsikrishna05 yes, I believe that would be an awesome course of action here! Thank you for handling this!

@nvamsikrishna05
Copy link
Collaborator Author

@ericmjl PR has been updated with the newer version of black formatted code also. You can review the changes and merge it.

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful stuff, thanks @nvamsikrishna05!

@ericmjl ericmjl merged commit 2d23e88 into pyjanitor-devs:dev Jul 19, 2021
@ericmjl
Copy link
Member

ericmjl commented Jul 19, 2021

@nvamsikrishna05 can you ping me via Shortwhale (http://www.shortwhale.com/ericmjl)? I'd like to invite you onto the dev team.

@nvamsikrishna05
Copy link
Collaborator Author

@ericmjl Sure. Doing it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants