-
Notifications
You must be signed in to change notification settings - Fork 173
[ENH] variable args for complete
#857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #857 +/- ##
==========================================
- Coverage 94.92% 94.92% -0.01%
==========================================
Files 19 19
Lines 2090 2089 -1
==========================================
- Hits 1984 1983 -1
Misses 106 106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work, @samukweku! I love the direction you've taken here, making the API much more uniform with variable args 😄
@samukweku could you resolve the conflicts and then ping back here? I think the PR has been open long enough that we should merge. 😄 |
Thanks @samukweku! |
PR Description
Please describe the changes proposed in the pull request:
complete
function.This PR improves
complete
function API.PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.