-
Notifications
You must be signed in to change notification settings - Fork 173
[DOC]Add missing functions to API docs Index #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #872 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 19 19
Lines 2078 2078
=======================================
Hits 1972 1972
Misses 106 106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small request, @samukweku - our config for pytest is in pyproject.toml!
Other than that, I think we're good to go 😄.
This being a docs PR, it's sufficient to have one review on it. I think we need to be a bit more conscientious with code reviews. Therefore, I merged with only myself as an official reviewer. Thanks @samukweku! 🎉 |
PR Description
Please describe the changes proposed in the pull request:
drop_constant_columns
andfactorize_columns
to the APIThis PR resolves #871 .
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.