Skip to content

[DOC]Add missing functions to API docs Index #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 18, 2021

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Aug 15, 2021

PR Description

Please describe the changes proposed in the pull request:

  • Add drop_constant_columns and factorize_columns to the API

This PR resolves #871 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #872 (62e26dc) into dev (5e2ccb3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #872   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          19       19           
  Lines        2078     2078           
=======================================
  Hits         1972     1972           
  Misses        106      106           

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small request, @samukweku - our config for pytest is in pyproject.toml!

Other than that, I think we're good to go 😄.

@ericmjl ericmjl merged commit b580ee7 into pyjanitor-devs:dev Aug 18, 2021
@ericmjl
Copy link
Member

ericmjl commented Aug 18, 2021

This being a docs PR, it's sufficient to have one review on it. I think we need to be a bit more conscientious with code reviews. Therefore, I merged with only myself as an official reviewer.

Thanks @samukweku! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add factorize_columns and drop_constant_columns to the API index
2 participants