-
Notifications
You must be signed in to change notification settings - Fork 173
[ENH] Process text #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Process text #878
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #878 +/- ##
==========================================
- Coverage 95.93% 95.79% -0.15%
==========================================
Files 19 19
Lines 2660 2618 -42
==========================================
- Hits 2552 2508 -44
- Misses 108 110 +2 |
I think I know what's going on with the code coverage - when |
@nvamsikrishna05 @loganthomas @ericmjl can I bother you a tiny bit to have a look at this PR. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor change requested, @samukweku 😄.
When it's done, @nvamsikrishna05 please do the honors!
CHANGELOG.md
Outdated
@@ -25,6 +25,7 @@ | |||
- [EHN] Set `expand_column`'s `sep` default is `"|"`, same to `pandas.Series.str.get_dummies`. Issue #876. @Zeroto521 | |||
- [ENH] Deprecate `limit` from fill_direction. fill_direction now uses kwargs. @samukweku | |||
- [ENH] Added `conditional_join` function that supports joins on non-equi operators. @samukweku | |||
- [ENH] Deprecate `new_column_names` and `merge_frame` from `process_text`. Only existing columns are supported. @samukweku |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take this line up to the top.
@nvamsikrishna05, my apologies; can i bother u with this PR? A second look and possible merge if all is good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samukweku Looks good. Sorry, I missed this PR for so long. Go ahead and merge it once all checks pass.
PR Description
Please describe the changes proposed in the pull request:
new_column_names
andmerge_frame
This PR improves
process_text
.PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.