Skip to content

[ENH] Process text #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Oct 2, 2021
Merged

[ENH] Process text #878

merged 34 commits into from
Oct 2, 2021

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Aug 17, 2021

PR Description

Please describe the changes proposed in the pull request:

  • Modifies only existing column
  • Deprecate new_column_names and merge_frame
  • keeping it simple (and easier to maintain)

This PR improves process_text.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku samukweku self-assigned this Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #878 (932fed8) into dev (ab6ae49) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #878      +/-   ##
==========================================
- Coverage   95.93%   95.79%   -0.15%     
==========================================
  Files          19       19              
  Lines        2660     2618      -42     
==========================================
- Hits         2552     2508      -44     
- Misses        108      110       +2     

@ericmjl
Copy link
Member

ericmjl commented Aug 20, 2021

I think I know what's going on with the code coverage - when dev has more lines of code than PR branch, it'll detect a decrease in the code coverage. Probably continually merging dev into the PR branch will fix that problem.

@samukweku
Copy link
Collaborator Author

@nvamsikrishna05 @loganthomas @ericmjl can I bother you a tiny bit to have a look at this PR. thanks

Copy link
Collaborator

@nvamsikrishna05 nvamsikrishna05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor change requested, @samukweku 😄.

When it's done, @nvamsikrishna05 please do the honors!

CHANGELOG.md Outdated
@@ -25,6 +25,7 @@
- [EHN] Set `expand_column`'s `sep` default is `"|"`, same to `pandas.Series.str.get_dummies`. Issue #876. @Zeroto521
- [ENH] Deprecate `limit` from fill_direction. fill_direction now uses kwargs. @samukweku
- [ENH] Added `conditional_join` function that supports joins on non-equi operators. @samukweku
- [ENH] Deprecate `new_column_names` and `merge_frame` from `process_text`. Only existing columns are supported. @samukweku
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take this line up to the top.

@samukweku
Copy link
Collaborator Author

@nvamsikrishna05, my apologies; can i bother u with this PR? A second look and possible merge if all is good

Copy link
Collaborator

@nvamsikrishna05 nvamsikrishna05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samukweku Looks good. Sorry, I missed this PR for so long. Go ahead and merge it once all checks pass.

@samukweku samukweku merged commit 67535f0 into pyjanitor-devs:dev Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants