[ENH] Fill direction #879
Merged
[ENH] Fill direction #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #879 +/- ##
==========================================
+ Coverage 94.89% 94.92% +0.02%
==========================================
Files 19 19
Lines 2078 2090 +12
==========================================
+ Hits 1972 1984 +12
Misses 106 106 |
|
@samukweku Looks good. |
ericmjl
approved these changes
Aug 18, 2021
| @@ -2523,7 +2521,7 @@ def row_to_names( | |||
| df = df.drop(df.index[range(row_number)]) | |||
|
|
|||
| if reset_index: | |||
| df.reset_index(drop=["index"], inplace=True) | |||
| df = df.reset_index(drop=["index"]) | |||
| @@ -37,6 +37,8 @@ | |||
| from scipy.stats import mode | |||
|
|
|||
| from .errors import JanitorError | |||
| from enum import Enum | |||
| from operator import methodcaller | |||
There was a problem hiding this comment.
Oh my, that is such Python trickery, @samukweku 😄 🤣
|
@nvamsikrishna05 would you like to do the honors? Please hit the big green button at your convenience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
This PR improves fill_direction.
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.rst.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.