-
Notifications
You must be signed in to change notification settings - Fork 173
[EHN] Set expand_column
's sep
default as "|"
#880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
expand_column
's sep
default is "|"
, same to pandas.Series.str.get_dummies
expand_column
's sep
default is "|"
, same to pandas.Series.str.get_dummies
expand_column
's sep
default is "|"
Codecov Report
@@ Coverage Diff @@
## dev #880 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 19 19
Lines 2090 2090
=======================================
Hits 1984 1984
Misses 106 106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zeroto521 thank you for the contribution! I like the change, as it's a sensible one, and I think we'd also appreciate just a bit more user-facing and developer-facing documentation for it. I only have two requested changes, if you could make those, I'm happy to approve the PR.
As is custom, I would also want to make sure we have two reviewers on the PR before we hit merge. Please hang tight; the team is distributed globally (AU, IN, US, etc.), it might take a bit of time for us to get to it!
expand_column
's sep
default is "|"
expand_column
's sep
default as "|"
Co-authored-by: Eric Ma <[email protected]>
…into expand_column
@samukweku when the checks are done, please feel free to do the honors! (Not worried about code coverage on this one either, the decrease doesn't seem to be reasonable... must be a bug with codecov I think.) |
PR Description
Please describe the changes proposed in the pull request:
expand_column
'ssep
default is"|"
, same topandas.Series.str.get_dummies
.This PR resolves #876.
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.