Skip to content

[ENH] Coalesce keyword args only #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Aug 22, 2021

PR Description

Please describe the changes proposed in the pull request:

  • Use keyword arguments for bfill and ffill
  • Use variable args for the column names (uses _select_columns under the hood)

This PR resolves #882

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #887 (0d33629) into dev (36d6a6b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #887   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          19       19           
  Lines        2448     2448           
=======================================
  Hits         2342     2342           
  Misses        106      106           

@samukweku
Copy link
Collaborator Author

@pyjanitor-devs/core-devs Hi Team; I'd appreciate your feedback if using variable args is worth using here (I may be overdoing it, since I like it)

Copy link
Collaborator

@nvamsikrishna05 nvamsikrishna05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @samukweku

@ericmjl
Copy link
Member

ericmjl commented Aug 30, 2021

@nvamsikrishna05 when the tests pass, please do the honors!

@nvamsikrishna05 nvamsikrishna05 merged commit 7360387 into pyjanitor-devs:dev Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Warning message in coalesce
3 participants