-
Notifications
You must be signed in to change notification settings - Fork 173
[ENH] Coalesce keyword args only #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Coalesce keyword args only #887
Conversation
…lesce_keyword_args_only
Codecov Report
@@ Coverage Diff @@
## dev #887 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 19 19
Lines 2448 2448
=======================================
Hits 2342 2342
Misses 106 106 |
@pyjanitor-devs/core-devs Hi Team; I'd appreciate your feedback if using variable args is worth using here (I may be overdoing it, since I like it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @samukweku
@nvamsikrishna05 when the tests pass, please do the honors! |
PR Description
Please describe the changes proposed in the pull request:
bfill
andffill
_select_columns
under the hood)This PR resolves #882
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.