[INF] simplify a bit linting, use pre-commit as CI linting checker

.devcontainer/noop.txt

@@ -1,3 +1,3 @@
 This file is copied into the container along with environment.yml* from the
-parent folder. This is done to prevent the Dockerfile COPY instruction from 
-failing if no environment.yml is found.
+parent folder. This is done to prevent the Dockerfile COPY instruction from
+failing if no environment.yml is found.

.github/workflows/code-checks.yml

@@ -3,70 +3,9 @@ name: Code style checks
 on: [push, pull_request]
 
 jobs:
-  black:
-    name: Check black compliance.
+  linting:
     runs-on: ubuntu-latest
-
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Setup Python
-        uses: actions/setup-python@v2
-
-      - name: Install black
-        run: python -m pip install black==21.7b0
-
-      - name: Run black
-        run: black --config pyproject.toml --check .
-
-  interrogate:
-    name: Check interrogate compliance.
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Setup Python
-        uses: actions/setup-python@v2
-
-      - name: Install interrogate
-        run: python -m pip install interrogate
-
-      - name: Run interrogate
-        run: interrogate .
-
-  darglint:
-    name: Check darglint compliance.
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Setup Python
-        uses: actions/setup-python@v2
-
-      - name: Install darglint
-        run: python -m pip install darglint
-
-      - name: Run darglint
-        run: darglint janitor -v 2
-
-  flake8:
-    name: Check flake8 compliance.
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Setup Python
-        uses: actions/setup-python@v2
-
-      - name: Install flake8
-        run: python -m pip install flake8
-
-      - name: Run flake8
-        run: flake8 . --exclude ./nbconvert_config.py
+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+      - uses: pre-commit/[email protected]

.pre-commit-config.yaml

@@ -12,12 +12,7 @@ repos:
   rev: 21.7b0
   hooks:
   - id: black
-    args: [-l 79]
-- repo: https://github.com/kynan/nbstripout
-  rev: 0.5.0
-  hooks:
-  - id: nbstripout
-    files: ".ipynb"
+    args: [--config, pyproject.toml]
 - repo: https://github.com/econchick/interrogate
   rev: 1.4.0
   hooks:
@@ -28,3 +23,8 @@ repos:
   hooks:
   - id: darglint
     args: [-v 2]  # this config makes the error messages a bit less cryptic.
+- repo: https://gitlab.com/pycqa/flake8
+  rev: 3.9.2
+  hooks:
+    - id: flake8
+      args: [--exclude, nbconvert_config.py]

CHANGELOG.md

@@ -1,6 +1,8 @@
 # Changelog
 
 ## [Unreleased]
+-   [INF] Simplify a bit linting, use pre-commit as the CI linting checker. @Zeroto521
+
 
 ## [v0.21.1] - 2021-08-29
 

docs/reference/janitor.functions/janitor.add_columns.md

@@ -3,4 +3,4 @@ janitor.add\_columns
 
 .. currentmodule:: janitor
 
-.. autofunction:: add_columns
+.. autofunction:: add_columns

docs/reference/janitor.functions/janitor.convert_excel_date.md

@@ -3,4 +3,4 @@ janitor.convert\_excel\_date
 
 .. currentmodule:: janitor
 
-.. autofunction:: convert_excel_date
+.. autofunction:: convert_excel_date

docs/reference/janitor.functions/janitor.currency_column_to_numeric.md

@@ -3,4 +3,4 @@ janitor.currency\_column\_to\_numeric
 
 .. currentmodule:: janitor
 
-.. autofunction:: currency_column_to_numeric
+.. autofunction:: currency_column_to_numeric

docs/reference/janitor.functions/janitor.filter_on.md

@@ -3,4 +3,4 @@ janitor.filter\_on
 
 .. currentmodule:: janitor
 
-.. autofunction:: filter_on
+.. autofunction:: filter_on

docs/reference/janitor.functions/janitor.find_replace.md

@@ -3,4 +3,4 @@ janitor.find\_replace
 
 .. currentmodule:: janitor
 
-.. autofunction:: find_replace
+.. autofunction:: find_replace

docs/reference/janitor.functions/janitor.get_dupes.md

@@ -3,4 +3,4 @@ janitor.get\_dupes
 
 .. currentmodule:: janitor
 
-.. autofunction:: get_dupes
+.. autofunction:: get_dupes

examples/notebooks/dirty_data.ipynb

@@ -480,4 +480,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 4
-}
+}

examples/notebooks/expand_grid.ipynb

@@ -215,4 +215,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 2
-}
+}

examples/notebooks/groupby_agg.ipynb

@@ -222,4 +222,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 4
-}
+}

examples/notebooks/pyjanitor_intro.ipynb

@@ -932,4 +932,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 4
-}
+}