Skip to content

[INF] Add SciPy as explicit dependency in base.in #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Conversation

ericmjl
Copy link
Member

@ericmjl ericmjl commented Sep 1, 2021

As per title.

Resolves #895.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #896 (8a0ae82) into dev (7360387) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #896   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          19       19           
  Lines        2448     2448           
=======================================
  Hits         2342     2342           
  Misses        106      106           

Copy link
Member

@loganthomas loganthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick response.

@ericmjl ericmjl merged commit 590e5a5 into dev Sep 1, 2021
@ericmjl ericmjl deleted the scipy-dependency branch September 1, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken scipy dependency on fresh install
3 participants