[DOC] MkDocs Utils Part 1 #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * [INF] simplify a bit linting There is two similar linting CIs (pre-commit and code-checks) but also have tiny differences. We should use one of them as the standard, not both. * Update CHANGELOG.md * should be `--config` not `-c` `-c` = `--code TEXT`, Format the code passed in as a string. * remove nbstripout keep the same with the old code-checks.yml * lint via pre-commit * Update CHANGELOG.md Co-authored-by: Eric Ma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## mkdocs #912 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 19 19
Lines 2448 2448
=======================================
Hits 2342 2342
Misses 106 106 |
ericmjl
approved these changes
Sep 6, 2021
|
@nvamsikrishna05 or @samukweku - one more review from either of you, and then please feel free to do the honors when you're done reviewing! |
nvamsikrishna05
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for docstring changes to utils submodule. Since utils has 74 functions, each PR will contain ~5 functions for review.
check()_strip_underscores()import_message()idempotent()deprecated_alias()