Skip to content

[ENH] Complete dict fix #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Oct 23, 2021
Merged

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Oct 17, 2021

PR Description

Please describe the changes proposed in the pull request:

  • Fix bug where complete fails if the args is just a dictionary of length 1, and the values is an instance of pd.Index.

This PR resolves #947 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #948 (d398baa) into dev (34935eb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #948      +/-   ##
==========================================
- Coverage   95.96%   95.96%   -0.01%     
==========================================
  Files          19       19              
  Lines        2530     2527       -3     
==========================================
- Hits         2428     2425       -3     
  Misses        102      102              

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are small enough to review easily. Thank you, @samukweku, for handling this!

@ericmjl ericmjl merged commit 915b124 into pyjanitor-devs:dev Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

complete fails for a dictionary with only one entry
2 participants