Skip to content

[ENH] Conditional_join #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Nov 2, 2021
Merged

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Nov 2, 2021

PR Description

Please describe the changes proposed in the pull request:

  • for inner join, build dataframe directly, instead of relying on concat (usually faster)
  • add fix for _range_indices to support dual column labels from df

This PR improves conditional_join.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #956 (ec40c96) into dev (9c4dcf1) will increase coverage by 0.01%.
The diff coverage is 98.27%.

@@            Coverage Diff             @@
##              dev     #956      +/-   ##
==========================================
+ Coverage   96.29%   96.30%   +0.01%     
==========================================
  Files          77       77              
  Lines        2805     2817      +12     
==========================================
+ Hits         2701     2713      +12     
  Misses        104      104              

@ericmjl ericmjl merged commit a84f93a into pyjanitor-devs:dev Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants