-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Drop support for Python 3.9 #10405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.9 #10405
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Thankfully UP038 is already deprecated, so I'll just ignore it. |
@@ -46,7 +46,7 @@ | |||
from pylint.lint.pylinter import PyLinter | |||
|
|||
|
|||
_AccessNodes = Union[nodes.Attribute, nodes.AssignAttr] | |||
_AccessNodes = type[nodes.Attribute | nodes.AssignAttr] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never seen this, is this correct? What if we stringify this annotation? Do you still need the type
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @cdce8p knows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8fd979c
to
7f2516c
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Jacob Walls <[email protected]>
7f2516c
to
38c82af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10405 +/- ##
==========================================
- Coverage 95.91% 95.87% -0.04%
==========================================
Files 176 176
Lines 19147 19137 -10
==========================================
- Hits 18364 18347 -17
- Misses 783 790 +7
🚀 New features to boost your workflow:
|
Remove support for launching pylint with Python 3.9.
Code that supports Python 3.9 can still be linted with the
--py-version=3.9
setting.