Fix py3k #3210
Merged
Fix py3k #3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCManticore
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Thanks for the PR @huguesb ! Left just a minor comment before getting this in.
| @@ -748,6 +748,11 @@ def error_mode(self): | |||
| def python3_porting_mode(self): | |||
| """Disable all other checkers and enable Python 3 warnings.""" | |||
| self.disable("all") | |||
| # re-enable some errors, or 'print', 'raise', 'async', 'await' will mistakenly lint fine | |||
There was a problem hiding this comment.
Can you use the symbolic names here instead? e.g. fatal, syntax-error and so on.
Enable syntax errors to properly surface invalid code in py3 porting mode, instead of silently swallowing them and giving the incorrect impression that the code is valid for py3. Closes pylint-dev#2956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable syntax errors to properly surface invalid code in py3
porting mode, instead of silently swallowing them and giving
the incorrect impression that the code is valid for py3.
🐛 Bug fix
Closes #2956