Skip to content

Bug pylint 4019 #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 8, 2021
Merged

Bug pylint 4019 #4311

merged 6 commits into from
Apr 8, 2021

Conversation

hippo91
Copy link
Contributor

@hippo91 hippo91 commented Apr 7, 2021

Steps

  • Add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

During detection of inconsistent-return-statements, consider that an assert False statement is equivalent to a return node.

Type of Changes

Type
🐛 Bug fix

Related Issue

Closes #4019

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !

@hippo91 hippo91 requested a review from cdce8p April 7, 2021 14:23
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Looks good overall!

@coveralls
Copy link

coveralls commented Apr 7, 2021

Coverage Status

Coverage increased (+0.001%) to 91.61% when pulling a55ba66 on hippo91:bug_pylint_4019 into 8b18d91 on PyCQA:master.

@hippo91 hippo91 merged commit 5540bd4 into pylint-dev:master Apr 8, 2021
@hippo91 hippo91 deleted the bug_pylint_4019 branch April 8, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent-return-statements with assert False in function call
4 participants