Skip to content

Add regression test for dataclass kw_only support #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Write a good description on what the PR does.
  • Create a news fragment with towncrier create <IssueNumber>.<type> which will be
    included in the changelog. <type> can be one of: new_check, removed_check, extension,
    false_positive, false_negative, bugfix, other, internal. If necessary you can write
    details or offer examples on how the new change is supposed to work.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
🐛 Bug fix

Description

Closes #7290, closes #6550, closes #5857

@DanielNoord DanielNoord added False Positive 🦟 A message is emitted but nothing is wrong with the code Needs astroid update Needs an astroid update (probably a release too) before being mergable dataclasses labels Sep 5, 2022
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobtylerwalls
Copy link
Member

Tentatively adding a milestone. @Pierre-Sassoulas shall we do an astroid patch update in pylint 2.15.1?

@jacobtylerwalls jacobtylerwalls added this to the 2.15.1 milestone Sep 5, 2022
@Pierre-Sassoulas
Copy link
Member

Yes, I created a release branch for astroid 2.12.6 already

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2999575598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.334%

Totals Coverage Status
Change from base Build 2999566143: 0.0%
Covered Lines: 17001
Relevant Lines: 17833

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit 1f3c6fe into pylint-dev:main Sep 6, 2022
@DanielNoord DanielNoord deleted the dataclasses-KW-ONLY branch September 6, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataclasses False Positive 🦟 A message is emitted but nothing is wrong with the code Needs astroid update Needs an astroid update (probably a release too) before being mergable
Projects
None yet
4 participants