Extend R1735 use-dict-literal to highlight all usages of dict that can be replaced with a literal #7691

hofrob · 2022-10-30T15:32:01Z

Type of Changes

	Type
✓	✨ New feature

Description

Refs #7690

Closes #7690

hofrob · 2022-10-30T15:36:45Z

This could very well be added to the existing R1735 check. I don't know what the general consensus is on extending existing messages.
The naming is kind of confusing now because use-dict-literal only covers empty dicts (dict()). So I decided to use use-dict-literal-without-kwargs for now though I think it adds to the confusion.
I'm not using a neat pylint feature right now: show how the code would look like if the suggestion is applied. I'd probably need some pointers to accomplish that.

Pierre-Sassoulas

Thank you for bringing a proof of concept with the issue 👌

I was also wondering if we should just extend what the existing message is doing or create another one. The former prevent user that don't want the new thing to disable it, but the second one add confusion. We could also rename the existing message to make things clearer and have the best of both world (?)

Regarding code suggestion, we should be careful to not create a behemoth message if the input dict is big we don't want a 400 lines message.

pylint/checkers/refactoring/refactoring_checker.py

coveralls · 2022-10-30T16:16:37Z

Pull Request Test Coverage Report for Build 3426938040

21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.0007%) to 95.388%

Files with Coverage Reduction	New Missed Lines	%
pylint/checkers/refactoring/refactoring_checker.py	1	98.13%

Totals
Change from base Build 3422307568:	-0.0007%
Covered Lines:	17268
Relevant Lines:	18103

💛 - Coveralls

pylint/checkers/refactoring/refactoring_checker.py

hofrob · 2022-10-30T17:02:10Z

I was also wondering if we should just extend what the existing message is doing or create another one. The former prevent user that don't want the new thing to disable it, but the second one add confusion. We could also rename the existing message to make things clearer and have the best of both world (?)

My personal opinion would be: Keep the name and code. Extend the functionality of the existing message. The name fits for both situations anyway.

People should expect new lint messages when upgrading the pylint package. But it's easy for me to say 😀 I don't have to work with huge code bases.

hofrob · 2022-10-30T17:25:20Z

Regarding the failing "readthedocs" build:

/home/docs/checkouts/readthedocs.org/user_builds/pylint/checkouts/7691/doc/whatsnew/2/2.16/index.rst:49: WARNING: Bullet list ends without a blank line; unexpected unindent.

No idea what to do here. My branch is up-to-date. Do I need to add anything else to the docs? Or is this related to the changes in pylint/pyreverse/?

Pierre-Sassoulas

Made some comments, I'm waiting for other maintainer opinion regarding the new message or the extension of the old one :)

script/.contributors_aliases.json

pylint/checkers/refactoring/refactoring_checker.py

Pierre-Sassoulas · 2022-10-30T18:19:42Z

There is surprisingly few violation on the primer which is a very good sign. The primer for sentry:

    use-dict-literal-without-kwargs:
    *Consider using a dict literal '

class dict(object):
"""dict() -> new empty dictionary
dict(mapping) -> new dictionary initiali...' instead.*

https://github.com/getsentry/sentry/blob/4be98deb27375dac541740b9c8d7ce871ff2bc99/src/sentry/api/endpoints/organization_sdk_updates.py#L44
Seems like something we need to fix though.

DanielNoord · 2022-10-30T19:31:26Z

I like the suggestion of extending the previous message!

hofrob · 2022-10-30T20:02:47Z

There is surprisingly few violation on the primer which is a very good sign. The primer for sentry:
    use-dict-literal-without-kwargs:
    *Consider using a dict literal '

class dict(object):
"""dict() -> new empty dictionary
dict(mapping) -> new dictionary initiali...' instead.*
https://github.com/getsentry/sentry/blob/4be98deb27375dac541740b9c8d7ce871ff2bc99/src/sentry/api/endpoints/organization_sdk_updates.py#L44 Seems like something we need to fix though.

I fixed those and added test cases. The code suggestion is now constructed "manually" to be able to handle **kwargs separate from actual keyword=value arguments.

hofrob · 2022-10-30T20:30:57Z

I like the suggestion of extending the previous message!

If you have the final say, I will go ahead. Or will others want to chime in?

DanielNoord · 2022-10-30T20:44:46Z

I like the suggestion of extending the previous message!

If you have the final say, I will go ahead. Or will others want to chime in?

They obviously can (and are encouraged to do so of course), but I think two maintainers thinking positively about this is a good sign to go ahead 😄

pylint/checkers/refactoring/refactoring_checker.py

Pierre-Sassoulas · 2022-10-30T20:58:37Z

It happened in the past that 2 maintainers agreed on something and another one made an argument so good we changed our mind but it's pretty rare 😄

hofrob · 2022-10-30T21:47:19Z

Ok, so I did the following:

one method that checks all calls to dict (meaning empty dicts are not separate anymore)
constructing the suggestion happens in a new private static method
I still use a list to construct the suggestion because handling commas would be a PITA otherwise 😁 (and set() won't work because it changes the order on every test run)
all tests, examples, docs merged into the existing use-dict-literal files/directories
cleaning up code in pylint that was highlighted by the new message resulted in another pylint message showing up (consider-using-namedtuple-or-dataclass), I will disable those

Important! The confidence level of an existing message changes

While it was still a separate message, we set the confidence to INFERENCE. This will change the confidence for existing messages for empty calls to dict(). Just so you're aware.

Pierre-Sassoulas

This looks pretty good already, thank you !

doc/data/messages/u/use-dict-literal/details.rst

doc/data/messages/u/use-dict-literal/good.py

pylint/checkers/refactoring/refactoring_checker.py

doc/whatsnew/fragments/7690.new_check

DudeNr33

Just some minor comments from my side. Looks good to me overall!
I'm also +1 for extending the existing message.

doc/data/messages/u/use-dict-literal/details.rst

doc/data/messages/u/use-dict-literal/good.py

doc/whatsnew/fragments/7690.new_check

doc/user_guide/checkers/features.rst

hofrob · 2022-11-01T13:10:42Z

I'm still unsure about the wording in doc/data/messages/u/use-dict-literal/details.rst. I'll gladly change this if you have something else in mind.

Btw. because I was curious I did a similar performance test with list joining compared to string concatenation: https://gist.github.com/hofrob/95b0d31ee4e168b876ecf82c92db2df4

Since we're using this in when creating the suggestion, I will leave it is.

Pierre-Sassoulas

This is looking better and better 🔥

doc/whatsnew/fragments/7690.new_check

pylint/checkers/refactoring/refactoring_checker.py

pylint/pyreverse/vcg_printer.py

tests/functional/u/use/use_literal_dict.txt

pylint/checkers/refactoring/refactoring_checker.py

Pierre-Sassoulas · 2022-11-01T13:42:15Z

pylint/checkers/refactoring/refactoring_checker.py

+        self._check_use_list_literal(node)
+        self._check_use_dict_literal(node)


The call to inferred = utils.safe_infer(node.func) is pretty costly, I think we should keep list/dict together for better performance.

I don't think we will prevent any calls to utils.safe_infer in this case. The list-check _check_use_list_literal will only do it if node.as_string() == "list()" and _check_use_dict_literal will always do it if isinstance(node.func, astroid.Name)¹.

The only thing we could improve are the checks _check_use_dict_literal¹, right? Doing both in one method will not have any effect. Or will it?

¹: I added a check there now: node.as_string().startswith("dict(")

¹: I added a check there now: node.as_string().startswith("dict(")

That "solution" sucks. I will do node.func.name != 'dict'.

Of course, this won't work for the following code:

foo = dict new_dict = foo(asdf=1)

But I think we can live with it for performance reasons?

I don't think we will prevent any calls to utils.safe_infer in this case. The list-check _check_use_list_literal will only do it if node.as_string() == "list()"

Fair point, I missed that.

Of course, this won't work for the following code:

foo = dict
new_dict = foo(asdf=1)

But I think we can live with it for performance reasons?

Yes definitely. Let's not punish everyone with slower linter to be accurate for those who redefine dict. They don't deserve a linter anyway 😄

pylint/checkers/refactoring/refactoring_checker.py

DudeNr33 · 2022-11-01T16:24:45Z

I'm still unsure about the wording in doc/data/messages/u/use-dict-literal/details.rst. I'll gladly change this if you have something else in mind.

Btw. because I was curious I did a similar performance test with list joining compared to string concatenation: https://gist.github.com/hofrob/95b0d31ee4e168b876ecf82c92db2df4

Since we're using this in when creating the suggestion, I will leave it is.

Sorry for the confusion - I actually liked that concrete number here, as it showed that we are not just talking about a 0.x % increase. I simply meant to add the Python version additionally, so we know in the future to what version this benchmark referred to.
Apart from that no more comments from my side. 😊 👍

hofrob · 2022-11-06T16:25:33Z

Sorry for the delay! I'm dealing with separate things for the moment.

Thanks for the feedback for now! I hope I'll be able to take another look in the course of the next week.

hofrob · 2022-11-08T19:06:35Z

I'm still unsure about the wording in doc/data/messages/u/use-dict-literal/details.rst. I'll gladly change this if you have something else in mind.
Btw. because I was curious I did a similar performance test with list joining compared to string concatenation: https://gist.github.com/hofrob/95b0d31ee4e168b876ecf82c92db2df4
Since we're using this in when creating the suggestion, I will leave it is.

Sorry for the confusion - I actually liked that concrete number here, as it showed that we are not just talking about a 0.x % increase. I simply meant to add the Python version additionally, so we know in the future to what version this benchmark referred to. Apart from that no more comments from my side. blush +1

Sorry, this was from a quick DM with @Pierre-Sassoulas. I added it back now:

https://gist.github.com/hofrob/ad143aaa84c096f42489c2520a3875f9

This example script shows an 18% increase in performance when using a literal over the
constructor in python version 3.10.6.

Pierre-Sassoulas

The primer looks pretty good now, there's a case when the last argument under a certain length is very long that does not get truncated:

Consider using '{"by": dict(((key, reverse_resolve_tag_value(self._use_case_id, self._organization_id, value, weak=True)) if groupby_alias_to_groupby_column.get(key) not in NON_RESOLVABLE_TAG_VALUES else (key, value) for (key, value) in tags)), … }' instead of a call to 'dict'.

But I think it's acceptable.

Great first contribution @hofrob, this is definitely going in 2.16.0 :)

pylint/checkers/refactoring/refactoring_checker.py

Pierre-Sassoulas · 2022-11-09T08:53:37Z

pylint/checkers/refactoring/refactoring_checker.py

+        self._check_use_list_literal(node)
+        self._check_use_dict_literal(node)


I don't think we will prevent any calls to utils.safe_infer in this case. The list-check _check_use_list_literal will only do it if node.as_string() == "list()"

Fair point, I missed that.

Of course, this won't work for the following code:

foo = dict
new_dict = foo(asdf=1)

But I think we can live with it for performance reasons?

Yes definitely. Let's not punish everyone with slower linter to be accurate for those who redefine dict. They don't deserve a linter anyway 😄

Pierre-Sassoulas · 2022-11-09T08:56:00Z

This test fail under Windows seems genuine.

hofrob · 2022-11-09T09:02:57Z

This test fail under Windows seems genuine.

Ah yes. This may have failed because of the ellipsis character … in features.rst since it happened during this command: command = ['--rcfile=d:\\a\\pylint\\pylint\\pylint\\testutils\\testing_pylintrc', '--full-documentation']

I replaced it with dots ... now. Can't really run the test locally, so let's see what the pipeline is going to say.

hofrob · 2022-11-09T09:33:52Z

FYI: I replaced all ellipsis characters with dots since there seems to be an issue with windows.

Details: When running the test test_self with the --full-documentation arg on windows, the following happens and no docs are returned: UnicodeDecodeError: 'utf-8' codec can't decode byte 0x85 in position 47771: invalid start byte

Pierre-Sassoulas · 2022-11-09T09:39:52Z

Details: When running the test test_self with the --full-documentation arg on windows, the following happens and no docs are returned:

Ha, right, probably the same encoding issue than with emojis in #7612. No need to use a unicode character for ellipsis, three dots are just fine.

github-actions · 2022-11-09T10:30:28Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on astroid:
The following messages are now emitted:

use-dict-literal:
Consider using '{"node": self, "unknown": node, "assign_path": assign_path, "context": context, ... }' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/protocols.py#L297
use-dict-literal:
Consider using '{"node": self, "unknown": node, "assign_path": assign_path, "context": context, ... }' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/protocols.py#L304
use-dict-literal:
Consider using '{"node": self, "unknown": node, "assign_path": assign_path, "context": context, ... }' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/protocols.py#L457
use-dict-literal:
Consider using '{"node": self, "unknown": node, "assign_path": assign_path, "context": context, ... }' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/protocols.py#L530
use-dict-literal:
Consider using '{"node": self, "unknown": node, "assign_path": assign_path, "context": context, ... }' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/protocols.py#L646
use-dict-literal:
Consider using '{"node": stmt, "context": context}' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/nodes/node_classes.py#L94
use-dict-literal:
Consider using '{"node": stmt, "context": context}' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/nodes/node_classes.py#L99
use-dict-literal:
Consider using '{"node": stmt, "context": context}' instead of a call to 'dict'.
https://github.com/PyCQA/astroid/blob/6cf238d089cf4b6753c94cfc089b4a47487711e5/astroid/nodes/node_classes.py#L107

Effect on flask:
The following messages are now emitted:

use-dict-literal:
Consider using '{"key_derivation": self.key_derivation, "digest_method": self.digest_method, ... }' instead of a call to 'dict'.
https://github.com/pallets/flask/blob/cc66213e579d6b35d9951c21b685d0078f373c44/src/flask/sessions.py#L350

Effect on pandas:
The following messages are now emitted:

use-dict-literal:
Consider using '{**_shared_docs}' instead of a call to 'dict'.
https://github.com/pandas-dev/pandas/blob/25832bc479dd794c588938b5d650126f9d8d9bff/pandas/core/window/doc.py#L8
use-dict-literal:
Consider using '{"x": 'A', "y": 'B', "c": 'c', "colormap": cmap}' instead of a call to 'dict'.
https://github.com/pandas-dev/pandas/blob/25832bc479dd794c588938b5d650126f9d8d9bff/pandas/tests/io/formats/style/test_matplotlib.py#L300

Effect on pytest:
The following messages are now emitted:

use-dict-literal:
Consider using '{"getfixture": self.fixture_request.getfixturevalue}' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/doctest.py#L282
use-dict-literal:
Consider using '{"DONT_ACCEPT_TRUE_FOR_1": doctest.DONT_ACCEPT_TRUE_FOR_1, "DONT_ACCEPT_BLANKLINE": doctest.DONT_ACCEPT_BLANKLINE, ... }' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/doctest.py#L385
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/doctest.py#L752
use-dict-literal:
Consider using '{"metafunc": metafunc}' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/python.py#L499
use-dict-literal:
Consider using '{"warning_message": warning_message, "nodeid": nodeid, "when": when, ... }' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/warnings.py#L65
use-dict-literal:
Consider using '{"plugin": plugin, "manager": self}' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/config/__init__.py#L492
use-dict-literal:
Consider using '{"parser": self._parser, "pluginmanager": self.pluginmanager}' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/config/__init__.py#L999
use-dict-literal:
Consider using '{"config": self}' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/config/__init__.py#L1037
use-dict-literal:
Consider using '{"pluginmanager": self.pluginmanager}' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/config/__init__.py#L1344
use-dict-literal:
Consider using '{"warning_message": records[0], "when": 'config', "nodeid": '', "location": location, ... }' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/config/__init__.py#L1400
use-dict-literal:
Consider using '{"black": 30, "red": 31, "green": 32, "yellow": 33, "blue": 34, "purple": 35, ... }' instead of a call to 'dict'.
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/_io/terminalwriter.py#L42

The following messages are no longer emitted:

use-dict-literal:
Consider using {} instead of dict()
https://github.com/pytest-dev/pytest/blob/a092b3ab360b1aa56ea35d3303ed33b460144124/src/_pytest/doctest.py#L752

Effect on sentry:
The following messages are now emitted:

use-dict-literal:
Consider using '{"geoip_lookup": rust_geoip, "max_secs_in_future": MAX_SECS_IN_FUTURE, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/constants.py#L571
use-dict-literal:
Consider using '{"start": start, "end": end, "groupby": groupby, "conditions": conditions, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/utils/snuba.py#L1187
use-dict-literal:
Consider using '{"partition_query": ' AND '.join(partition_query) + (' AND ' if partition_query else ''), ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/utils/query.py#L236
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/utils/jwt.py#L74
use-dict-literal:
Consider using '{"organization": organization}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/api/bases/organizationmember.py#L67
use-dict-literal:
Consider using '{"suggestions": list(get_suggested_updates(SdkSetupState(latest['sdkName'], latest['sdkVersion'], (), ()), index_state, ignore_patch_version=True)), ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/api/endpoints/organization_sdk_updates.py#L44
use-dict-literal:
Consider using '{"include_values_seen": True}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/api/endpoints/project_tags.py#L19
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/api/helpers/group_index/update.py#L691
use-dict-literal:
Consider using '{"url": f'/organizations/{org_slug}/integrations/{obj.key}/setup/', ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/api/serializers/models/integration.py#L170
use-dict-literal:
Consider using '{"constructor": NormalizedUserIpEvent}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/region_to_control/messages.py#L62
use-dict-literal:
Consider using '{"constructor": NormalizedAuditLogEvent}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/region_to_control/messages.py#L66
use-dict-literal:
Consider using '{"user_id": user_ip_event.user_id, "ip_address": user_ip_event.ip_address, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/region_to_control/consumer.py#L109
use-dict-literal:
Consider using '{"key": redis_key, "limit": limit, "request_uid": request_uid}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/ratelimits/concurrent.py#L53
use-dict-literal:
Consider using '{"key": key, "request_uid": request_uid}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/ratelimits/concurrent.py#L79
use-dict-literal:
Consider using '{"value": original_data}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/db/mixin.py#L54
use-dict-literal:
Consider using '{"by": dict(((key, reverse_resolve_tag_value(self._use_case_id, self._organization_id, value, weak=True)) if groupby_alias_to_groupby_column.get(key) not in NON_RESOLVABLE_TAG_VALUES else (key, value) for (key, value) in tags)), ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/snuba/metrics/query_builder.py#L906
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/profiles/task.py#L167
use-dict-literal:
Consider using '{"data": data}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/models/processingissue.py#L89
use-dict-literal:
Consider using '{"group": group, "project_id": group.project_id, "linked_type": GroupLink.LinkedType.issue, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/models/grouplink.py#L27
use-dict-literal:
Consider using '{"organization_id": self._release.organization_id, "release_id": self._release.id, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/models/releasefile.py#L359
use-dict-literal:
Consider using '{"integration": integration, "organization__organizationintegration__integration": integration, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/models/integrations/external_issue.py#L27
use-dict-literal:
Consider using '{"method": str(request.method), "view": view, "response": status_code, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/middleware/access_log.py#L83
use-dict-literal:
Consider using '{"host": '%s:%d' % (host, port), "userid": dsn.username, "password": dsn.password, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/monitoring/queues.py#L37
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/tagstore/snuba/backend.py#L599
use-dict-literal:
Consider using '{"user_id__isnull": False, "user__is_active": True}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/tasks/reports.py#L779
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/sentry_metrics/configuration.py#L51
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/utils/sync.py#L25
use-dict-literal:
Consider using '{"member_set__user": user, "organizationintegration__integration": integration, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/utils/identities.py#L28
use-dict-literal:
Consider using '{"id": organization_id}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/utils/identities.py#L34
use-dict-literal:
Consider using '{"oauth_scopes": sorted(GitlabIdentityProvider.oauth_scopes), "redirect_url": absolute_uri('/extensions/gitlab/setup/'), ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/gitlab/integration.py#L335
use-dict-literal:
Consider using '{"oauth_scopes": (), "redirect_url": absolute_uri('/extensions/github-enterprise/setup/'), ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/github_enterprise/integration.py#L271
use-dict-literal:
Consider using '{"user": user, "key": 'issue:defaults', "project": project}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/mixins/issues.py#L168
use-dict-literal:
Consider using '{"user": user, "key": 'issue:defaults', "project": project}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/mixins/issues.py#L178
use-dict-literal:
*Consider using '{"jwt": encoded_jwt, *url_params or {}}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/jira/client.py#L71
use-dict-literal:
Consider using '{"method": method, "path": path, "data": data, "params": params}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/jira/client.py#L73
use-dict-literal:
Consider using '{"method": method, "path": path, "data": data, "params": params}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/jira_server/client.py#L73
use-dict-literal:
Consider using '{"external_name": channel_name, "external_id": channel_id}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/slack/views/link_team.py#L132
use-dict-literal:
*Consider using '{"query": query, *args}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/slack/unfurl/discover.py#L288
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/features/manager.py#L100
use-dict-literal:
Consider using '{"category": get_path(frame_data, 'data', 'category'), "family": get_behavior_family_for_platform(frame_data.get('platform') or platform), ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/grouping/enhancer/matchers.py#L63
use-dict-literal:
Consider using '{"ignore_unknown_options": True}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/runner/__init__.py#L91
use-dict-literal:
Consider using '{"ignore_unknown_options": True, "allow_extra_args": True}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/runner/commands/exec.py#L19
use-dict-literal:
Consider using '{"email": email, "username": email, "is_superuser": superuser, "is_staff": staff, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/runner/commands/createuser.py#L109
use-dict-literal:
Consider using '{"ignore_unknown_options": True, "allow_extra_args": True}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/runner/commands/execfile.py#L8
use-dict-literal:
Consider using '{"ignore_unknown_options": True}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/runner/commands/django.py#L6
use-dict-literal:
Consider using '{"start": start, "end": end, "project_ids": [p.id for p in projects], ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/search/snuba/executors.py#L697
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/javascript/errorlocale.py#L10
use-dict-literal:
Consider using '{"type": {'type': 'string', 'enum': ['http']}, "url": {'type': 'string'}, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/native/symbolicator.py#L81
use-dict-literal:
Consider using '{"type": {'type': 'string', 'enum': ['s3']}, "bucket": {'type': 'string'}, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/native/symbolicator.py#L94
use-dict-literal:
Consider using '{"type": {'type': 'string', 'enum': ['gcs']}, "bucket": {'type': 'string'}, ... }' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/native/symbolicator.py#L109
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/native/symbolicator.py#L683
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/native/appconnect.py#L162
use-dict-literal:
Consider using '{"task_name": self.name}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/bgtasks/api.py#L43
use-dict-literal:
Consider using '{"task_name": self.name}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/bgtasks/api.py#L56
use-dict-literal:
Consider using '{"task_name": self.name}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/bgtasks/api.py#L62
use-dict-literal:
Consider using '{}' instead of a call to 'dict'.
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/notifications/helpers.py#L230

The following messages are no longer emitted:

use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/utils/jwt.py#L74
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/api/helpers/group_index/update.py#L691
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/profiles/task.py#L167
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/tagstore/snuba/backend.py#L599
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/sentry_metrics/configuration.py#L51
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/integrations/utils/sync.py#L25
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/features/manager.py#L100
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/javascript/errorlocale.py#L10
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/native/symbolicator.py#L683
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/lang/native/appconnect.py#L162
use-dict-literal:
Consider using {} instead of dict()
https://github.com/getsentry/sentry/blob/8f53000b026f763fb849c40c7fb05277e22bb2c9/src/sentry/notifications/helpers.py#L230

Effect on coverage:
The following messages are now emitted:

use-dict-literal:
Consider using '{"Name": '{:{name_len}}', "Stmts": '{:>7}', "Miss": '{:>7}', "Branch": '{:>7}', ... }' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/summary.py#L52
use-dict-literal:
Consider using '{"Cover": '{:>{n}}%'}' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/summary.py#L72
use-dict-literal:
Consider using '{"Name": '| {:{name_len}}|', "Stmts": '{:>9} |', "Miss": '{:>9} |', ... }' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/summary.py#L106
use-dict-literal:
Consider using '{"Cover": '{:>{n}}% |'}' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/summary.py#L128
use-dict-literal:
Consider using '{"Name": '|{:>{name_len}} |', "Cover": '{:>{n}} |'}' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/summary.py#L136
use-dict-literal:
Consider using '{"name": 0, "stmts": 1, "miss": 2, "cover": -1}' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/summary.py#L182
use-dict-literal:
Consider using '{"branch": 3, "brpart": 4}' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/summary.py#L184
use-dict-literal:
Consider using '{"morfs": unglob_args(args), "ignore_errors": options.ignore_errors, ... }' instead of a call to 'dict'.
https://github.com/nedbat/coveragepy/blob/bc630b58b5d1c58cc8108e584a480f3a1cd5ab70/coverage/cmdline.py#L676

This comment was generated for commit a552780

DanielNoord

Love this change! Thanks very much!

Pierre-Sassoulas added Enhancement ✨ Improvement to a component Needs design proposal 🔒 This is a huge feature, some discussion should happen before a PR is proposed labels Oct 30, 2022

Pierre-Sassoulas reviewed Oct 30, 2022

View reviewed changes

pylint/checkers/refactoring/refactoring_checker.py Outdated Show resolved Hide resolved

pylint/checkers/refactoring/refactoring_checker.py Outdated Show resolved Hide resolved

hofrob requested a review from DudeNr33 as a code owner October 30, 2022 16:45

hofrob commented Oct 30, 2022

View reviewed changes

pylint/checkers/refactoring/refactoring_checker.py Outdated Show resolved Hide resolved

Pierre-Sassoulas reviewed Oct 30, 2022

View reviewed changes

script/.contributors_aliases.json Show resolved Hide resolved

pylint/checkers/refactoring/refactoring_checker.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Pierre-Sassoulas removed the Needs design proposal 🔒 This is a huge feature, some discussion should happen before a PR is proposed label Oct 30, 2022

Pierre-Sassoulas added this to the 2.16.0 milestone Oct 30, 2022

This comment has been minimized.

Sign in to view

Pierre-Sassoulas reviewed Oct 30, 2022

View reviewed changes

pylint/checkers/refactoring/refactoring_checker.py Outdated Show resolved Hide resolved

hofrob changed the title ~~Add R1737 use-dict-literal-without-kwargs~~ Extend R1735 use-dict-literal to highlight all usages of dict that can be replaced with a literal Oct 30, 2022

Pierre-Sassoulas requested changes Oct 31, 2022

View reviewed changes

Pierre-Sassoulas reviewed Oct 31, 2022

View reviewed changes

pylint/checkers/refactoring/refactoring_checker.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

mbyrnepr2 reviewed Oct 31, 2022

View reviewed changes

doc/whatsnew/fragments/7690.new_check Outdated Show resolved Hide resolved

DudeNr33 requested changes Nov 1, 2022

View reviewed changes

hofrob requested review from DudeNr33 and Pierre-Sassoulas and removed request for DudeNr33 November 1, 2022 13:10

Pierre-Sassoulas requested changes Nov 1, 2022

View reviewed changes

DudeNr33 previously approved these changes Nov 1, 2022

View reviewed changes

DudeNr33 mentioned this pull request Nov 1, 2022

Use namedtuple or dataclass for pyreverse arrow options #7700

Open

This comment has been minimized.

Sign in to view

hofrob dismissed DudeNr33’s stale review via bf20c73 November 8, 2022 19:02

This comment has been minimized.

Sign in to view

Pierre-Sassoulas previously approved these changes Nov 9, 2022

View reviewed changes

hofrob dismissed Pierre-Sassoulas’s stale review via 9513264 November 9, 2022 09:00

Add R1737 use-dict-literal-without-kwargs

a552780

Pierre-Sassoulas approved these changes Nov 9, 2022

View reviewed changes

DanielNoord approved these changes Nov 9, 2022

View reviewed changes

DanielNoord merged commit 0507ee3 into pylint-dev:main Nov 9, 2022

		self._check_use_list_literal(node)
		self._check_use_dict_literal(node)

Uh oh!

Extend R1735 use-dict-literal to highlight all usages of dict that can be replaced with a literal #7691

Extend R1735 use-dict-literal to highlight all usages of dict that can be replaced with a literal #7691

Uh oh!

Conversation

hofrob commented Oct 30, 2022

Type of Changes

Description

Uh oh!

hofrob commented Oct 30, 2022

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coveralls commented Oct 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 3426938040

💛 - Coveralls

Uh oh!

Uh oh!

hofrob commented Oct 30, 2022

Uh oh!

hofrob commented Oct 30, 2022

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Pierre-Sassoulas commented Oct 30, 2022

Uh oh!

DanielNoord commented Oct 30, 2022

Uh oh!

hofrob commented Oct 30, 2022

Uh oh!

This comment has been minimized.

hofrob commented Oct 30, 2022

Uh oh!

DanielNoord commented Oct 30, 2022

Uh oh!

Uh oh!

Pierre-Sassoulas commented Oct 30, 2022

Uh oh!

hofrob commented Oct 30, 2022

Important! The confidence level of an existing message changes

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

DudeNr33 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hofrob commented Nov 1, 2022

Uh oh!

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pierre-Sassoulas Nov 1, 2022

Choose a reason for hiding this comment

coveralls commented Oct 30, 2022 •

edited

Loading

hofrob Nov 8, 2022 •

edited

Loading

Pierre-Sassoulas commented Nov 9, 2022 •

edited

Loading