[use-implicit-booleaness] Fix comparison to empty strings across the codebase #7722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codebase As it will become a default check in pylint-dev#6870 it will be easier to review it if we separate the two
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 7dfbbd3 |
Pierre-Sassoulas
added
Maintenance
Pull Request Test Coverage Report for Build 3403656884
💛 - Coveralls |
DanielNoord
approved these changes
Nov 7, 2022
Pierre-Sassoulas
deleted the
fix-compare-to-empty-string-existing-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refactor prior to #6870 where
compare-to-empty-stringwill become a default check integrated inuse-implicit-booleanessand will start to be enforced. It will be easier to review if we separate the two. Similar to #7721