Fix false positive for 'used-before-assignment' with terminating func #7784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3491561420
💛 - Coveralls |
Pierre-Sassoulas
added
False Positive 🦟
Pierre-Sassoulas
previously approved these changes
Nov 17, 2022
|
Primer failure reminds me of when primer had a legit error but it didn't show up in CI, so I'll run locally when I can and report back. |
clavedeluna
force-pushed
the
7563-exit
branch
from
d492531 to
64ddfa7
Compare
Pierre-Sassoulas
approved these changes
Nov 17, 2022
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 64ddfa7 |
Pierre-Sassoulas
changed the title
Pierre-Sassoulas
added
the
Needs backport
Pierre-Sassoulas
removed
Needs backport
|
Not back-porting because of a refactor in |
cdce8p
reviewed
Nov 21, 2022
| ): | ||
| return False | ||
|
|
||
| qnames = {"_sitebuiltins.Quitter", "sys.exit", "posix._exit", "nt._exit"} |
There was a problem hiding this comment.
Small nit: This could be a global, maybe even a frozenset. That would be a small performance improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #7563
If a terminating func such as sys.exit, quit, etc is used in an else statement,
used-before-assignmentshould not be flagged.