Emit used-before-assignment for further imports guarded by TYPE_CHECKING
#7806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CKING Previously, this message was only emitted for imports guarded directly under TYPE_CHECKING, not guarded two if-branches deep, nor when TYPE_CHECKING was imported from typing under an alias.
jacobtylerwalls
added
False Negative 🦋
Pull Request Test Coverage Report for Build 3548460782
💛 - Coveralls |
Pierre-Sassoulas
previously approved these changes
Nov 20, 2022
jacobtylerwalls
commented
Nov 20, 2022
This comment has been minimized.
This comment has been minimized.
|
The false positive in flask is already documented at #7609. It's true that this PR will ever so slightly drive more traffic into that false positive, but I don't think that's a reason not to merge it, because whenever someone picks it up, we'll immediately backport it. EDIT: I opened #7810 to fix it |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit f9fea0f |
|
@Pierre-Sassoulas This one's ready for review, if you get a chance. |
Pierre-Sassoulas
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Previously, this message was only emitted for imports guarded directly under TYPE_CHECKING, not guarded two if-branches deep, nor when TYPE_CHECKING was imported from typing under an alias.
Closes #7539