Skip to content

[code owner] Remove areveny from her checkers temporarily #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

No availability for review right now, so the automated review request is a bit much. It's possible to stay a pylint member without being spammed for it. (@areveny fyi)

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry labels Jan 16, 2023
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to just remove these then and then revert this commit when necessary.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #8065 (e4a84bc) into main (4a5b4e6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8065   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files         176      176           
  Lines       18545    18545           
=======================================
  Hits        17698    17698           
  Misses        847      847           

@Pierre-Sassoulas
Copy link
Member Author

I think reverting the commit is harder than removing the # and I feel like this file is a documentation about who master what in the repositories regardless of who actually get pinged for review but feel free to suggest/change/merge :)

@DanielNoord
Copy link
Collaborator

I think reverting the commit is harder than removing the # and I feel like this file is a documentation about who master what in the repositories regardless of who actually get pinged for review but feel free to suggest/change/merge :)

Yeah completely agree, but I don't like keeping stuff on main that is dependent on people's live. I completely trust that @areveny hopes to have more time in the future, but we never know if that will actually happen. Feels better to handle that when it actually does.

No availability for review right now, so the automated review request
is a bit much. It's possible to stay a pylint member without being
spammed for it.
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Pierre-Sassoulas Pierre-Sassoulas merged commit b87cf16 into main Jan 17, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the Pierre-Sassoulas-patch-1 branch January 17, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants