Skip to content

removed unused *args from fit, added named args to sampler_config #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged

removed unused *args from fit, added named args to sampler_config #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pymc_experimental/model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ def fit(
progressbar: bool = True,
random_seed: RandomState = None,
data: Dict[str, Union[np.ndarray, pd.DataFrame, pd.Series]] = None,
*args: Any,
**kwargs: Any,
) -> az.InferenceData:
"""
Expand Down Expand Up @@ -269,6 +268,10 @@ def fit(
if self.sampler_config is None:
self.sampler_config = sampler_config
self.build_model(self.model_data, self.model_config)

sampler_config["progressbar"] = progressbar
sampler_config["random_seed"] = random_seed

with self.model:
self.idata = pm.sample(**self.sampler_config, **kwargs)
self.idata.extend(pm.sample_prior_predictive())
Expand Down