Updates to Mixture docs. #2799
Merged
Updates to Mixture docs. #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
reviewed
Jan 15, 2018
pymc3/distributions/mixture.py
Outdated
| # 2-Mixture Poisson distribution | ||
| with pm.Model() as model: | ||
| lam = pm.Exponential('lam', lam=1, shape=(2,)) # `shape=(2,)` indicates two mixtures. | ||
| components = pm.Poisson.dist(mu=lam, shape=(2,)) # must use dist, not plain Poisson object! |
There was a problem hiding this comment.
I would adjust the comment a bit, maybe: # as we just need the logp, rather than add a RV to the model, we need to call .dist()
minor wording change
|
Thanks @ericmjl! |
|
My pleasure! |
twiecki
reviewed
Jan 18, 2018
|
|
||
| Example | ||
| ------- | ||
| # 2-Mixture Poisson distribution |
There was a problem hiding this comment.
This doesn't display correctly. Need to add the code tag.
There was a problem hiding this comment.
Just to check: should be .. code-block:: python?
There was a problem hiding this comment.
http://livesphinx.herokuapp.com/ is directionally helpful
There was a problem hiding this comment.
(that is to say, yes, that's it, but then it needs a newline after it, and possibly indentation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@junpenglao @ColCarroll this is the new PR having nuked my fork and started over 😄.
Please review!