Version 3.8 #3698
Merged
Version 3.8 #3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3698 +/- ##
======================================
Coverage 89.9% 89.9%
======================================
Files 134 134
Lines 20269 20269
======================================
Hits 18223 18223
Misses 2046 2046 |
|
They all pass! |
|
Are we sure that tests passing is sufficient? Just wanna make sure 😄. |
|
Necessary, but not sufficient -- we've spent a few weeks trying to shake out bugs and slowdowns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure tests still pass, then releasing.