Skip to content

Implement multinomial and inverse gamma in numba backend #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 19, 2025

Also changes the python implementation to use numpy instead of scipy. The overhead doesn't make sense for this trivial RV.

Long term we should replace these by OpFromGraph: #1221


📚 Documentation preview 📚: https://pytensor--1223.org.readthedocs.build/en/1223/

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (e25e8a2) to head (7fdfe64).
Report is 145 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/link/numba/dispatch/random.py 44.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
- Coverage   82.03%   82.01%   -0.02%     
==========================================
  Files         188      188              
  Lines       48535    48559      +24     
  Branches     8676     8679       +3     
==========================================
+ Hits        39814    39824      +10     
- Misses       6558     6572      +14     
  Partials     2163     2163              
Files with missing lines Coverage Δ
pytensor/tensor/random/basic.py 98.84% <100.00%> (ø)
pytensor/link/numba/dispatch/random.py 55.80% <44.00%> (-1.40%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit a920c09 into pymc-devs:main Feb 19, 2025
73 of 74 checks passed
@ricardoV94 ricardoV94 deleted the numba_multinomial_and_inv_gamma branch April 21, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants