Skip to content

Don't run the PyPi job all the time #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Apr 9, 2025

This was mostly Claude-generated changes, so appreciate careful review.

Trying to save tons of compute time we wast building the cython-scan extension on the ubuntu wheel for every PR and push to main. Closes #219


📚 Documentation preview 📚: https://pytensor--1363.org.readthedocs.build/en/1363/

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (0c398e3) to head (9e2235e).
Report is 85 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
+ Coverage   82.05%   82.12%   +0.07%     
==========================================
  Files         203      211       +8     
  Lines       48863    49757     +894     
  Branches     8695     8819     +124     
==========================================
+ Hits        40093    40862     +769     
- Misses       6619     6715      +96     
- Partials     2151     2180      +29     

see 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 requested review from maresb and lucianopaz April 9, 2025 18:08
Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like there's potential to group the whole condition of the if job runs into an output of the check_changes job. I'm not sure how to do that though. Maybe Claude knows. I've added a suggestion on to kind of hint at what I mean.

@ricardoV94 ricardoV94 added the help wanted Extra attention is needed label May 30, 2025
@ricardoV94
Copy link
Member Author

ricardoV94 commented May 30, 2025

Would either of you @lucianopaz or @maresb be willing to take the PR over the finish line?

@maresb
Copy link
Contributor

maresb commented May 30, 2025

Would either of you @lucianopaz or @maresb be willing to take the PR over the finish line?

I'm overwhelmed at the moment. You can try pinging me again in a few weeks

@lucianopaz
Copy link
Member

I can take over next week

@ricardoV94
Copy link
Member Author

I can take over next week

Super

@lucianopaz lucianopaz self-assigned this Jun 8, 2025
@lucianopaz lucianopaz marked this pull request as ready for review June 8, 2025 21:08
@lucianopaz
Copy link
Member

Looks like the check_changes job isn't setting the correct output and some jobs are skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wheels on Ubuntu CI takes a long time
3 participants