Update vendored library: packaging #7559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the new packaging has types, it includes a py.typed. No harm in including this in our package, and it may facilitate debug tool usage on an installed pip by signaling that pip._vendor.packaging is type-annotated.
chrahunt
added
project: vendored dependency
xavfernandez
approved these changes
Jan 6, 2020
pradyunsg
reviewed
Jan 7, 2020
| @@ -21,6 +21,7 @@ exclude tox.ini | |||
| exclude noxfile.py | |||
|
|
|||
| recursive-include src/pip/_vendor *.pem | |||
| recursive-include src/pip/_vendor py.typed | |||
There was a problem hiding this comment.
Hmm, I don't think there's much point in doing this -- we're shadowing the relevant modules through .pyi files in the vendor directory.
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #6908. Split from #7354.