-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Ran autofixes for missing-return-type-special-method (ANN204)
with ignore-fully-untyped = false
#4802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
missing-return-type-special-method (ANN204)
with with
ignore-fully-untyped = false`missing-return-type-special-method (ANN204)
with ignore-fully-untyped = false
0e4ada1
to
8eadd7a
Compare
missing-return-type-special-method (ANN204)
with ignore-fully-untyped = false
missing-return-type-special-method (ANN204)
with ignore-fully-untyped = false
395be5d
to
7541b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @Avasam and sorry for the delay.
I am not sure what will be the policy regarding modifying the pkg_resource
files now that it has been scheduled for removal and that Jason has spent some time exporting the commit history to the pypa/pkg_resources
repo. I also don't know if there are plans of keep updating that other repo or if it was a simple experiment.
Maybe @jaraco can clarify what is his preference.
Oh yeah this PR was created before #5007 |
7541b67
to
b54ae61
Compare
…`ignore-fully-untyped = false`
b54ae61
to
77514d3
Compare
I've excluded |
For future reference, avoid changing pkg_resources. I want to avoid committing anything here that we'd miss there, assuming we decide to use it. But if it's convenient or it happens that we change something here, it's no big deal. Don't sweat it either way. |
When it comes to checkers (Ruff, mypy, pyright), the |
I set
[lint.flake8-annotations] ignore-fully-untyped = false
then ranruff check --select=ANN204 --fix --unsafe-fixes
Summary of changes
Step 6.3 of #2345 (comment)
Some slight overlaps with #4744
Pull Request Checklist
newsfragments/
. (not user facing)(See documentation for details)