Skip to content

Ran autofixes for missing-return-type-special-method (ANN204) with ignore-fully-untyped = false #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Jan 14, 2025

I set [lint.flake8-annotations] ignore-fully-untyped = false then ran ruff check --select=ANN204 --fix --unsafe-fixes

Summary of changes

Step 6.3 of #2345 (comment)
Some slight overlaps with #4744

Pull Request Checklist

@Avasam Avasam changed the title missing-return-type-special-method (ANN204) with with ignore-fully-untyped = false` missing-return-type-special-method (ANN204) with ignore-fully-untyped = false Jan 14, 2025
@Avasam Avasam force-pushed the ANN204-wo-ignore-fully-untyped branch from 0e4ada1 to 8eadd7a Compare January 21, 2025 00:16
@Avasam Avasam changed the title missing-return-type-special-method (ANN204) with ignore-fully-untyped = false Ran autofixes for missing-return-type-special-method (ANN204) with ignore-fully-untyped = false May 15, 2025
@Avasam Avasam force-pushed the ANN204-wo-ignore-fully-untyped branch from 395be5d to 7541b67 Compare May 28, 2025 20:14
Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Avasam and sorry for the delay.

I am not sure what will be the policy regarding modifying the pkg_resource files now that it has been scheduled for removal and that Jason has spent some time exporting the commit history to the pypa/pkg_resources repo. I also don't know if there are plans of keep updating that other repo or if it was a simple experiment.

Maybe @jaraco can clarify what is his preference.

@Avasam
Copy link
Contributor Author

Avasam commented May 28, 2025

Oh yeah this PR was created before #5007

@Avasam Avasam force-pushed the ANN204-wo-ignore-fully-untyped branch from 7541b67 to b54ae61 Compare May 30, 2025 00:54
@Avasam Avasam force-pushed the ANN204-wo-ignore-fully-untyped branch from b54ae61 to 77514d3 Compare May 30, 2025 00:55
@Avasam
Copy link
Contributor Author

Avasam commented May 30, 2025

I've excluded pkg_resources from this PR.

@jaraco
Copy link
Member

jaraco commented May 30, 2025

For future reference, avoid changing pkg_resources. I want to avoid committing anything here that we'd miss there, assuming we decide to use it. But if it's convenient or it happens that we change something here, it's no big deal. Don't sweat it either way.

@Avasam
Copy link
Contributor Author

Avasam commented May 30, 2025

When it comes to checkers (Ruff, mypy, pyright), the pkg_resources folder can just be ignored, even on a per-rule basis. Makes it easy to keep automatically enforcing project practices without touching pkg_resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants