Skip to content

chore: update license headers to use shorter SPDX header #18148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

miketheman
Copy link
Member

Instead of the longer license header, replace with a shorter SPDX version.

Refs: https://spdx.dev/learn/handling-license-info/

@miketheman
Copy link
Member Author

I'm considering that this might be a good idea to split out part of this PR to separate PRs so that we can use the .git-blame-ignore-revs feature to remove the change from a normal git blame.

If you do think it's a good idea, I'd split out to two PRs:

  • the license checker and docs change
  • all the remaining license header changes, including translations

Once merged & deployed, a third PR to add a .git-blame-ignore-revs file with the commit hash of the actual license header changes.

I don't feel strongly about this, but wanted to surface the ability in case that was a concern.

@miketheman miketheman marked this pull request as ready for review May 22, 2025 22:02
@miketheman miketheman requested a review from a team as a code owner May 22, 2025 22:02
@miketheman
Copy link
Member Author

CodeQL failures are due to touching files, and thus scanning "changed" files, so nothing is actually new here.

@ewdurbin
Copy link
Member

I'm:

  • +1 to the outcome/intent.
  • NULL on the actual implications of this from a licensing concern (this document says it's fine/sufficient but I am not an expert).
  • +1 to including handling of .git-blame-ignore-revs to keep this from cluttering blame history

Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say go for it, but with git blame ignore handling.

@miketheman
Copy link
Member Author

Excellent! Converting back to draft to split apart and ship parts to accomplish the git blame ignore

@miketheman miketheman marked this pull request as draft May 30, 2025 13:24
@miketheman
Copy link
Member Author

Closing now that the deed is done, and the ignore is part of #18219

@miketheman miketheman closed this Jun 2, 2025
@miketheman miketheman deleted the miketheman/idea-licenses branch June 2, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants