Skip to content

Suggestion: Using capturemanager.global_and_fixture_disabled #172

Open
@AbdealiLoKo

Description

@AbdealiLoKo

I came across some odd behavior when I was debugging something related to terminal logging in pytest.
And noticed pytest-timeout was disabling capturemanager and doing it's own printing
Ref: https://github.com/pytest-dev/pytest-timeout/blob/2.3.1/pytest_timeout.py#L511

I think the better approach here may be to use global_and_fixture_disabled which is a context manager to temporarily disable capturemanager and write your own terminal outputs while it is disabled
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/capture.py#L819

Any thoughts on whether this would make the logging logic simpler here?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions