-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add activate command alias for env commad #10339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add activate command alias for env commad #10339
Conversation
…le in console commands folder that matches the new alias.
Reviewer's Guide by SourceryThis pull request introduces a new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sharan-Robinson - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a test to ensure that the
activate
command functions identically toenv activate
.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
docs/managing-environments.md
Outdated
@@ -86,6 +86,8 @@ The `poetry env activate` command prints the activate command of the virtual env | |||
You can run the output command manually or feed it to the eval command of your shell to activate the environment. | |||
This way you won't leave the current shell. | |||
|
|||
The `poetry activate` command acts an alias for `poetry env activate` and is interchangeable with each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Typo: "acts an alias" should be "acts as an alias"
The `poetry activate` command acts an alias for `poetry env activate` and is interchangeable with each other. | |
The `poetry activate` command acts as an alias for `poetry env activate` and is interchangeable with each other. |
Pull Request Check List
Resolves: #10266
This PR adds a new command called activate that acts as an alias for the "env activate" command.
Summary by Sourcery
Add an alias command 'activate' for the existing 'env activate' command in Poetry
New Features:
Documentation:
Tests: