-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-129640: Add tests for reference cycle in gzip.GzipFile
#130916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mr-Sunglasses
wants to merge
13
commits into
python:main
Choose a base branch
from
Mr-Sunglasses:fix/129640
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
06999db
gh-129640: Fix reference cycle in `gzip.GzipFile`
Mr-Sunglasses 79b7f6c
test: Add test for reference cycle in `gzip.GzipFile`
Mr-Sunglasses 327f877
chore: add news entry
Mr-Sunglasses eefc287
docs: Add refence to the function in the NEWS
Mr-Sunglasses ee93a71
test: Add refence to the issue in the test comment.
Mr-Sunglasses c17135e
Merge branch 'main' into fix/129640
Mr-Sunglasses 0dbcd08
Merge branch 'main' into fix/129640
Mr-Sunglasses 5b9f6e6
REVERT the changes in `gzip` module
Mr-Sunglasses 8826606
Merge branch 'fix/129640' of github.com:Mr-Sunglasses/cpython into fi…
Mr-Sunglasses 67b4dd2
chore: removed news entry
Mr-Sunglasses e6aa09d
docs: Add the reference of `GH-129726` in tests
Mr-Sunglasses 94fa2a8
Merge branch 'main' into fix/129640
Mr-Sunglasses 13f1006
Merge branch 'main' into fix/129640
Mr-Sunglasses File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2025-03-06-20-25-54.gh-issue-129640.iub32dw1.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fixed a reference cycle in ``gzip.GzipFile`` when writing to a file. | ||
Mr-Sunglasses marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.